Hi Marc, On Tue, Jul 19, 2016 at 3:46 PM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: > On 19/07/16 14:25, Geert Uytterhoeven wrote: >> On Wed, Jul 6, 2016 at 4:33 PM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: >>> On a big-little system, PMUs can be wired to CPUs using per CPU >>> interrups (PPI). In this case, it is important to make sure that >>> the enable/disable do happen on the right set of CPUs. >>> >>> So instead of relying on the interrupt-affinity property, we can >>> use the actual percpu affinity that DT exposes as part of the >>> interrupt specifier. The DT binding is also updated to reflect >>> the fact that the interrupt-affinity property shouldn't be used >>> in that case. >>> >>> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx> >>> --- >>> * From v1: >>> - propagate the error if irq_get_percpu_devid_partition fails >> >> This patch, which is commit 19a469a58720ea96 in arm64/for-next/core, broke >> the PMU on r8a7740/armadillo800eva: >> >> -hw perfevents: enabled with armv7_cortex_a9 PMU driver, 7 >> counters available >> +hw perfevents: /pmu: failed to probe PMU! >> +hw perfevents: /pmu: failed to register PMU devices! >> +armv7-pmu: probe of pmu failed with error -22 > Thanks for the thorough analysis. Could you please give the following > patchlet a go: > > diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c > index 2513365..9275e08 100644 > --- a/drivers/perf/arm_pmu.c > +++ b/drivers/perf/arm_pmu.c > @@ -958,11 +958,12 @@ static int of_pmu_irq_cfg(struct arm_pmu *pmu) > > /* If we didn't manage to parse anything, try the interrupt affinity */ > if (cpumask_weight(&pmu->supported_cpus) == 0) { > - if (!using_spi) { > + int irq = platform_get_irq(pdev, 0); > + > + if (irq_is_percpu(irq)) { > /* If using PPIs, check the affinity of the partition */ > - int ret, irq; > + int ret; > > - irq = platform_get_irq(pdev, 0); > ret = irq_get_percpu_devid_partition(irq, &pmu->supported_cpus); > if (ret) { > kfree(irqs); > > > and let me know if that helps? Thanks, that fixes it, as expected. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html