[Re: [v10, 3/7] soc: fsl: add GUTS driver for QorIQ platforms] On 15/07/2016 (Fri 14:12) Scott Wood wrote: > On Fri, 2016-07-15 at 12:43 -0400, Paul Gortmaker wrote: > > > +source "drivers/soc/fsl/qe/Kconfig" [...] > > > + > > > +config FSL_GUTS > > > + bool > > > diff --git a/drivers/soc/fsl/Makefile b/drivers/soc/fsl/Makefile > > > index 203307f..02afb7f 100644 > > > --- a/drivers/soc/fsl/Makefile > > > +++ b/drivers/soc/fsl/Makefile > > > @@ -4,3 +4,4 @@ > > > > > > obj-$(CONFIG_QUICC_ENGINE) += qe/ > > > obj-$(CONFIG_CPM) += qe/ > > > +obj-$(CONFIG_FSL_GUTS) += guts.o > > > diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c > > > new file mode 100644 > > > index 0000000..fa155e6 > > > --- /dev/null > > > +++ b/drivers/soc/fsl/guts.c > > > @@ -0,0 +1,119 @@ > > > +/* > > > + * Freescale QorIQ Platforms GUTS Driver > > > + * > > > + * Copyright (C) 2016 Freescale Semiconductor, Inc. > > > + * > > > + * This program is free software; you can redistribute it and/or modify > > > + * it under the terms of the GNU General Public License as published by > > > + * the Free Software Foundation; either version 2 of the License, or > > > + * (at your option) any later version. > > > + */ > > > + > > > +#include <linux/io.h> > > > +#include <linux/module.h> > > Seems there was lots of discussion on this. If it does end up being > > resent, it would be nice to get the module.h and other modular stuff > > gone since it is a bool Kconfig. > > I plan to resend just the GUTS driver portion and send it through the PPC > tree. > > I don't see any modular stuff in there besides the linux/module.h include. Great. Normally I'm seeing the MODULE_DEVICE_TABLE and MODULE_AUTHOR and MODULE_LICENSE etc, so it has (unfortunately) become a knee jerk reaction to assume the latter follows a module.h presence... thanks for removing the extraneous include. Paul. -- > > -Scott > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
