On Fri 15 Jul 00:07 PDT 2016, njaigane@xxxxxxxxxxxxxx wrote: > From: Jaiganesh Narayanan <njaigane@xxxxxxxxxxxxxx> > > This patch adds the tlmm/pinctrl support for IPQ4019 ASoC. > > Signed-off-by: Jaiganesh Narayanan <njaigane@xxxxxxxxxxxxxx> > --- > drivers/pinctrl/qcom/pinctrl-ipq4019.c | 116 +++++++++++++++++++++++++-------- > 1 file changed, 88 insertions(+), 28 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c [..] > + qca_mux_i2s_rx_mclk, > + qca_mux_i2s_rx_bclk, > + qca_mux_i2s_rx_fsync, > + qca_mux_i2s_rxd, > + qca_mux_i2s_tx_mclk, > + qca_mux_i2s_tx_bclk, > + qca_mux_i2s_tx_fsync, > + qca_mux_i2s_txd1, > + qca_mux_i2s_txd2, > + qca_mux_i2s_txd3, > + qca_mux_i2s_spdif_out, > + qca_mux_i2s_spdif_in, I would recommend reducing this to "i2s_rx", "i2s_tx", "spdif_rx" and "spdif_tx", as this will make the dts cleaner. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html