On Fri, Jul 15, 2016 at 10:31 AM, Andrey Pronin <apronin@xxxxxxxxxxxx> wrote: > On Thu, Jul 14, 2016 at 09:05:53PM -0700, Guenter Roeck wrote: >> On Thu, Jul 14, 2016 at 7:20 PM, Andrey Pronin <apronin@xxxxxxxxxxxx> wrote: >> > + >> > +Required properties: >> > +- compatible: Should be "google,cr50_spi". >> >> google,cr50, maybe ? The "_spi" seems redundant. >> > > I believe "_spi" is warranted. It's the driver that handles the SPI > interface for Cr50 specifically. > But if the same firmware ever talks through a different interface (say, > I2C), this driver will not be compatible. > I meant in the context of it being attached to a spi device, which implies that it is connected through a spi bus. Guenter >> Also, I agree with comments from others - the term cr50 really needs >> an explanation (Google thinks that it is a motor bike, a scanner, or a >> coffee roaster). >> > > Yes, will add a better description of what it is. My original one was > too brief and imprecise at the same time. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
