On 2016年07月11日 23:36, Arnd Bergmann wrote:
On Sunday, July 10, 2016 3:27:23 PM CEST Wan Zongshun wrote:
+config NUC900_TIMER
+ bool "Clocksource timer for nuc900 platform" if COMPILE_TEST
+ depends on ARM
+ select CLKSRC_OF if OF
+ select CLKSRC_MMIO
+ help
+ Enables the clocksource for the NUC900 platform.
I have put this patch into my randconfig build system and found that
it lacks a dependency:
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index e18ef32776a3..59b9251eef37 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -523,7 +523,7 @@ config CLKSRC_ST_LPC
config NUC900_TIMER
bool "Clocksource timer for nuc900 platform" if COMPILE_TEST
- depends on ARM
+ depends on ARM && GENERIC_CLOCKEVENTS
select CLKSRC_OF if OF
select CLKSRC_MMIO
help
So this patch, I still need submit or you have merged it?
Also the init function has changed its return type in linux-next:
+static void __init nuc970_timer_of_init(struct device_node *node)
This now needs to return an error code or we get:
../include/linux/of.h:1004:20: error: comparison of distinct pointer types lacks a cast [-Werror]
.data = (fn == (fn_type)NULL) ? fn : fn }
Daniel Lezcano seems to have implemented a migration strategy, but I
can't see what you are supposed to do here, since the
CLOCKSOURCE_OF_DECLARE_RET macro is no longer part of linux-next.
Wait for Daniel's comments? or what should I do now?
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
