On 28/06/2016 at 15:57:04 -0500, Rob Herring wrote : > On Mon, Jun 27, 2016 at 08:19:22PM +0900, Akinobu Mita wrote: > > This adds support control with GPIO lines connected to the DS1302 > > which can communicate with three wires. > > > > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> > > Cc: Sergey Yanovich <ynvich@xxxxxxxxx> > > Cc: Alessandro Zummo <a.zummo@xxxxxxxxxxxx> > > Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/rtc/maxim-ds1302.txt | 13 + > > drivers/rtc/Kconfig | 17 +- > > drivers/rtc/rtc-ds1302.c | 320 ++++++++++++++++++++- > > 3 files changed, 331 insertions(+), 19 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/rtc/maxim-ds1302.txt b/Documentation/devicetree/bindings/rtc/maxim-ds1302.txt > > index ba470c5..d489753 100644 > > --- a/Documentation/devicetree/bindings/rtc/maxim-ds1302.txt > > +++ b/Documentation/devicetree/bindings/rtc/maxim-ds1302.txt > > @@ -27,6 +27,12 @@ Required SPI properties: > > - spi-cs-high: DS-1302 has active high chip select line. This is > > required unless inverted in hardware. > > > > +Required properties when using GPIO lines: > > + > > +- gpio-ce: GPIO connected to CE pin > > +- gpio-io: GPIO connected to I/O pin > > +- gpio-reset: GPIO connected to SCLK pin > > + > > IIRC, we got rid of the direct gpio bit-banging in this driver (or a > similar one) and replaced it with SPI GPIO driver. We should do that > here. > Well, the fact is that it is not actually SPI but microwire which has different timings and we didn't reach a conclusion yet with Mark. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
