Re: [RFC/PATCH] dt: Add of_device_compatible_match()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, 2016-07-07 at 09:42 -0700, Frank Rowand wrote:
> 
> of_device_is_compatible() returns a higher value for a better match.
> 
> of_fdt_match() returns a lower value for a better match.

Ugh ... that smells of trainwreck...

> So checking for (tmp < score) will give you the opposite of what you want.

Yup. I'll fix it.

> And if you are replacing of_fdt_match() with of_device_compatible_match(),
> the caller will have the expectation that a smaller score is a better
> match.

The few callers I converted only really cared about exact matches.

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux