On 16.06.2016 10:40, Jisheng Zhang wrote:
> This patch adds the L2 cache topology for berlin4ct which has 1MB L2
> cache.
>
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> index 099ad93..c9e3a98 100644
> --- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
> +++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi
[...]
> @@ -92,9 +95,14 @@
> device_type = "cpu";
> reg = <0x3>;
> enable-method = "psci";
> + next-level-cache = <&L2_0>;
> cpu-idle-states = <&CPU_SLEEP_0>;
> };
>
> + L2_0: l2-cache0 {
Jisheng,
The node name should just have a generic name that reflects
the purpose of the unit it represents, i.e.
s/l2-cache0/cache/
nits:
- What is that "0" for? Please remove if there is no good reason.
- Does the node label need to be upper-case? Please make it lower case.
Sebastian
> + compatible = "cache";
> + };
> +
> idle-states {
> entry-method = "psci";
> CPU_SLEEP_0: cpu-sleep-0 {
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
