Hi Rob, > > The ir-spi is a simple device driver which supports the > > connection between an IR LED and the MOSI line of an SPI device. > > Please split the binding from the driver. OK! > > +Device tree bindings for IR LED connected through SPI bus which is used as > > +remote controller. > > Do said devices have part numbers? Seems kind of generic and I've never > seen such device. No, it doesn't, this is a simple irled driven by the SPI MOSI line that works as a remote controller. It looked strange to me as well when I heard of it the first time, but it will be present in the upcoming tm2/tm2e patchset (i.e. Samsung Note 4 and Note 4 edge). > > +Optional properties: > > + - irled,switch: specifies the gpio switch which enables the irled > > Just "switch-gpios" OK! > > + controller-data { > > This is part of the controller binding? Omit that from the example. OK! Thanks, Andi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html