On Tue, Jul 5, 2016 at 1:04 AM, Andreas Färber <afaerber@xxxxxxx> wrote: > +/dts-v1/; > + > +#include "imx6sx-udoo-neo.dtsi" > + > +/ { > + model = "UDOO Neo Basic"; This should be something like: model = "Udoo i.MX6 SoloX UDOO Neo Basic"; > + compatible = "fsl,imx6sx"; compatible = "udoo,imx6sx-udoo-neo", "fsl,imx6sx"; Then you can also send a separate patch to add udoo to Documentation/devicetree/bindings/vendor-prefixes.txt. Same applies to other places in this patch. > +&fec1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_enet1>; > + phy-mode = "rmii"; > + phy-reset-gpios = <&gpio5 4 GPIO_ACTIVE_HIGH>; Shouldn't this be GPIO_ACTIVE_LOW instead? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html