Hello, On Tue, Jul 05, 2016 at 06:04:09AM +0200, Andreas Färber wrote: > +&iomuxc { > + imx6sx-udoo-neo { There is no need for this machine group. Please just put the pinctrl groups directly into &iomuxc { }. > + pinctrl_enet1: enet1grp { > + fsl,pins = > + <MX6SX_PAD_ENET1_CRS__GPIO2_IO_1 0xa0b1>, > + <MX6SX_PAD_ENET1_MDC__ENET1_MDC 0xa0b1>, It's unusual to write pinmuxes this way. The usual form is to write it in a single array. (Not sure I'm using the right term here.) Having said that I like it your way, but still it should (IMHO) get a more official blessing. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html