On Sat, Jul 02, 2016 at 03:32:43PM +0200, Alexandre Belloni wrote: > > > > I believe that the best way to deal with this is to add an > > > > "allwinner,general-purpose-mode" flag to the existing binding > > > > (as well as document general purpose mode in the existing > > > > binding rather then in a new binding doc). > > > > > > > > That seems to be the right thing to do purely looking at this > > > > from a dt binding pov. > > > > > > There's a way simpler solution: if there's no child nodes, it's meant > > > to be used as an ADC, otherwise, as input. > > > > > > The logic will have to be a bit more complex than that, since there's > > > two channels, and you could only require one for the buttons, leaving > > > the other one available as an ADC. > > > > > > But that doesn't require any new property. > > > > True, if there are no button nodes, then go general-purpose will > > work too. > > Well, I'd still argue that we need two different compatibles because > encoding the usage of an IP in its compatible string is less than ideal. That's true, but it's what we have. So feel free to add a new compatible if you want, but we'll have to support the old one anyway. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
