Hi Sebastian, Am Freitag, den 01.07.2016, 00:52 +0200 schrieb Sebastian Reichel: > Hi, > > On Thu, Jun 30, 2016 at 10:05:41PM +0200, Karl-Heinz Schneider wrote: > > This patch adds device tree documentation for the sbs-manager > > > > Reviewed-by: Phil Reid <preid@xxxxxxxxxxxxxxxxx> > > Signed-off-by: Karl-Heinz Schneider <karl-heinz@xxxxxxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/power/sbs,sbs-manager.txt | 52 ++++++++++++++++++++++ > > 1 file changed, 52 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/power/sbs,sbs-manager.txt > > > > diff --git a/Documentation/devicetree/bindings/power/sbs,sbs-manager.txt b/Documentation/devicetree/bindings/power/sbs,sbs-manager.txt > > new file mode 100644 > > index 0000000..1d7e5ee > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/power/sbs,sbs-manager.txt > > @@ -0,0 +1,52 @@ > > +Binding for sbs-manager > > + > > +Required properties: > > +- compatible: should be "lltc,ltc1760" or use "sbs,sbs-manager" as fallback. > > +- reg: integer, i2c address of the device. Should be <0xa>. > > + > > +From OS view the device is basically an i2c-mux used to communicate with up to > > +four smart battery devices at address 0xb. The driver actually implements this > > +behaviour. So standard i2c-mux nodes can be used to register up to four slave > > +batteries. Channels will be numerated as 1, 2, 4 and 8. > > I think it's better to use channel 1-4 and do the translation in the > driver's channel select method. It means one does not have to worry > about anybody accidently configuring channel 3 and it also maps > nicely to the datasheet talking about BAT1-BAT4. You're not the first one pointing that out... Will fix that in the next revision. > > -- Sebastian -- Greetings -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html