Arnd Bergmann wrote:
If the ranges property lists the bus as dma capable for only the
lower 32 bits, then dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
should fail, otherwise dma_alloc_coherent() will return an invalid
memory area.
That seems wrong. dma_alloc_coherent() should be smart enough to
restrict itself to the the dma-ranges property. Isn't that why the
property exists? When dma_alloc_coherent() looks for memory, it should
knows it has to create a 32-bit address. That's why we have ZONE_DMA.
Another twist is how arm64 currently uses SWIOTLB unconditionally:
As long as SWIOTLB (or iommu) is enabled, dma_set_mask_and_coherent()
should succeed for any mask(), but not actually update the mask of the
device to more than the bus can handle.
That just seems like a bug in ARM64 SWIOTLB. SWIOTLB should inject
itself when the driver tries to map memory outside of its DMA range.
In this case, SWIOTLB/IOMMU is handling the translation from low memory
to high memory, eliminating the need to restrict memory access to a
specific physical range.
Without SWIOTLB/IOMMU, dma_alloc_coherent() should be aware of the
platform-specific limitations of each device and ensure that it only
allocates memory that conforms *all* limitations. For example, if the
platform is capable of 64-bit DMA, but a legacy device can only handle
32-bit bus addresses, then the driver should do this:
dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32))
If there's no SWIOTLB or IOMMU, then dma_alloc_coherent() should
allocate only 32-bit addresses.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
