Re: [PATCH v4 3/3] gpio: lp873x: Add support for General Purpose Outputs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 






On Wednesday 29 June 2016 04:15 PM, Manish Badarkhe wrote:
Hi Keerthy,

sorry ignore my last two comments in previous mail.

On Wed, Jun 29, 2016 at 4:13 PM, Manish Badarkhe
<badarkhe.manish@xxxxxxxxx> wrote:
Hi Keerthy

Some minor comment

+static int lp873x_gpio_direction_output(struct gpio_chip *chip,
+                                       unsigned int offset, int value)
+{
+       struct lp873x_gpio *gpio = gpiochip_get_data(chip);
+
+       /* Set the initial value */
+       regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL,
+                          BIT(offset * 4), value ? BIT(offset * 4) : 0);
+
+       return 0;
+}

  Error needs to be return, this function always return 0.

Yes! I can just do:

return regmap_update_bits(gpio->lp873->regmap, LP873X_REG_GPO_CTRL,
                          BIT(offset * 4), value ? BIT(offset * 4) : 0);


  Regards
  Manish Badarkhe

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux