Re: [PATCH v2 3/8] Input: synaptics-rmi4: Add dribble and palm gesture parameters to device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, Jun 24, 2016 at 05:18:37PM -0700, Andrew Duggan wrote:
> Signed-off-by: Andrew Duggan <aduggan@xxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/input/rmi4/rmi_2d_sensor.txt          |  4 ++++
>  drivers/input/rmi4/rmi_2d_sensor.c                            | 11 +++++++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> index f2c30c8..86cb8e3 100644
> --- a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> +++ b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt
> @@ -37,6 +37,10 @@ Optional Properties:
>  				disable reporing absolute position data.
>  - syna,rezero-wait-ms: Time in miliseconds to wait after issuing a rezero
>  				command.
> +- syna,dribble-enable: Enable reporting of dribble packets in the firmware.
> +- syna,dribble-disable: Disable reporting of dribble packets in the firmware.
> +- syna,palm-detect-enable: Enable reporting the palm detect gesture in the firmware.
> +- syna,palm-detect-disable: Disable reporting the palm detect gesture in the firmware.

No need for enable and disable. Make the common case be no property and 
the property is the opposite.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux