Hi,
On Tue, Jun 28, 2016 at 10:10:57AM +0200, Carlo Caione wrote:
> On 27/06/16 18:28, Mark Rutland wrote:
> > On Sun, Jun 19, 2016 at 02:38:59PM +0200, Carlo Caione wrote:
> > > + np = of_find_matching_node_and_match(NULL, meson_sm_ids, &matched_np);
> > > + if (!np) {
> > > + pr_err("no matching node\n");
> > > + return -EINVAL;
> > > + }
> > > +
> >
> > This is going to be pointlessly noisy on every non-amlogic board out
> > there.
>
> ouch, right
>
> > Please make this a platform driver, such that this is only called when a
> > node is present, avoiding some mess there.
>
> Since Rob required this to be under /firmware (and using no "simple-bus"
> compatible to trigger the automatic creation) making it a platform
> driver just adds a lot of boilerplate code. If this doesn't mean a NACK
> on your side, I still would leave the code as is with the
> device_initcall() calling the init.
Ok. So long as this isn't noisy where the node is not present, that's
fine by me.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
