On 28/06/16 08:22, Neil Armstrong wrote: > On 06/27/2016 06:44 PM, Ben Dooks wrote: >> Apologies, forgot to put the RTC driver through checkpatch >> before sending. This gets rid of most of the warnings. >> >> >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlogic@xxxxxxxxxxxxxxxxxxx >> http://lists.infradead.org/mailman/listinfo/linux-amlogic >> > > Hi Ben, > > The patchset looks good but misses some quick introduction on how > the RTC works, it seems to be connected to an internal serial bus, > do you have some informations about this ? I might add a few lines into the rtc-meson.c driver, but that's all detailed in the datasheet (for once this seems to be documented enough to be able to function) > Then, the cover letter of your patchset should contain much more informations > that "git format-patch --cover-letter" generates. I may just re-submit once patch to add the RTC and the binding documentation, and then wait until the reset controller bits have landed before submitting the > My personal workflow when I have a set ready is : > > * run checkpatch on C files and check my changes > # scripts/checkpatch.pl -f path/to/my/driver.c > * I identify the number of patches to include > * I generate the patches with cover-letter, signoff and eventually subject-prefix, here for 4 commits > # git format-patch --cover-letter -s -4 --subject-prefix "PATCH v2" -o my_drivers_patches_v2 > * Then I complete the cover letter in my_drivers_patches_v2/0000-cover-letter > * I also reference a small changelog between patchset version and identify the previous cover letter via it's message id > Use the http://lkml.kernel.org service to reference a message-id, i.e this email I answer would be referenced by : > http://lkml.kernel.org/r/1467045849-495-1-git-send-email-ben.dooks@xxxxxxxxxxxxxxx I keep a copy of sent email anyway, so can get the message-ids out of it. > while looking at the email headers at : > Message-Id: <1467045849-495-1-git-send-email-ben.dooks@xxxxxxxxxxxxxxx> > * Then I look again all the patches and check all the descriptions > * I re-run a checkpatch.pl on all the patches (and ignore errors on the cover letter) > # scripts/checkpatch.pl my_drivers_patches_v2/* > * I identify all the maintainers and mailing lists > # scripts/get_maintainer.pl my_drivers_patches_v2/* > * Personally, I fill the CC: and To: in the headers of each patches, only adding the devicetree mailing list on DT related patches > * Then I send them via git send-email > # git send-email my_drivers_patches_v2/* > => here you can also select the recipients > => you can also do a dry run or send yourself the patchset to check before final sending I got sparse and checkpatch confused, and only did sparse on the series. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
