On Thu, Jun 23, 2016 at 12:45:13PM +0200, Sylwester Nawrocki wrote: > + /* Select analog input by default */ > + regmap_write(map, MAX98504_REG_SPEAKER_SOURCE_SELECT, 0x1); This should be done by userspace configuration, just leave the chip at power on defaults. This is policy so that we don't have people trying to patch their configurations into the kernel. > + /* Brownout protection enable */ > + regmap_write(map, MAX98504_REG_PVDD_BROWNOUT_ENABLE, 0x1); > + /* Threshold 2.9V, 3dB speaker attenuation*/ > + regmap_write(map, MAX98504_REG_PVDD_BROWNOUT_CONFIG(1), 0x33); > + /* Attack hold time 10 ms */ > + regmap_write(map, MAX98504_REG_PVDD_BROWNOUT_CONFIG(2), 0x0a); > + /* Brownout hold time 255 ms, brownout release time 255 ms */ > + regmap_write(map, MAX98504_REG_PVDD_BROWNOUT_CONFIG(3), 0xff); > + regmap_write(map, MAX98504_REG_PVDD_BROWNOUT_CONFIG(4), 0xff); Should these be DT properties?
Attachment:
signature.asc
Description: PGP signature
