Re: [PATCH] ARM: dts: sun7i: Add BCM53125 Device Tree nodes

[Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>]

Hi Florian,

On Sat, Jun 25, 2016 at 07:59:23PM -0700, Florian Fainelli wrote:
> Le 23/06/2016 22:48, Chen-Yu Tsai a écrit :
> >> diff --git a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
> >> index 5ee43d8bf174..697582397dcf 100644
> >> --- a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
> >> +++ b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
> >> @@ -110,13 +110,67 @@
> >>  &gmac {
> >>         pinctrl-names = "default";
> >>         pinctrl-0 = <&gmac_pins_rgmii_a>;
> >> -       phy = <&phy1>;
> >>         phy-mode = "rgmii";
> >>         phy-supply = <&reg_gmac_3v3>;
> >>         status = "okay";
> >>
> >> -       phy1: ethernet-phy@1 {
> >> -               reg = <1>;
> >> +       fixed-link {
> >> +               speed = <1000>;
> >> +               full-duplex;
> >> +       };
> >> +
> >> +       mdio1 {
> > 
> > mdio will suffice.
> 
> There is another label in sun7i-a20.dtsi named mdio which is for the
> MDIO controller node matching allwinner,sun4i-a10-mdio, which is not the
> one we want here, we want the MDIO controller associated with the
> Synopsys GMAC.

Yes, but it's in a different node, and you're not using any labels, so
I don't really see how that would conflict.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature