Hello,
thank you for the review.
On 24.6.2016 04:41, Chen-Yu Tsai wrote:
> On Fri, Jun 24, 2016 at 3:20 AM, <megous@xxxxxxxxxx> wrote:
>> From: Josef Gajdusek <atx@xxxxxxxx>
>>
>> Add a node describing the Security ID memory to the Allwinner H3 .dtsi file.
>>
>> Signed-off-by: Josef Gajdusek <atx@xxxxxxxx>
>> ---
>> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
>> index 4a4926b..172576d 100644
>> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
>> @@ -389,6 +389,13 @@
>> #size-cells = <0>;
>> };
>>
>> + sid: eeprom@01c14000 {
>> + compatible = "allwinner,sun4i-a10-sid";
>
> This has been discussed before. The hardware is not compatible.
> The write control registers are at different offsets.
I'm not sure what you mean by write control registers. Code in
sunxi_sid.c implements only read access to the nvram. Can you pelase
elaborate?
Ondrej
>
> ChenYu
>
>> + reg = <0x01c14000 0x400>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + };
>> +
>> usbphy: phy@01c19400 {
>> compatible = "allwinner,sun8i-h3-usb-phy";
>> reg = <0x01c19400 0x2c>,
>> --
>> 2.9.0
>>
Attachment:
signature.asc
Description: OpenPGP digital signature
