On Thu, Jun 23, 2016 at 11:38 AM, Grygorii Strashko <grygorii.strashko@xxxxxx> wrote: >> This solves the big problem with the current global numbering system >> in /sys/class/gpio/* > > Hm. May be i misunderstood samthing (and sry, if my following question > is dummy as I've not followed closely new GPIO ABI development), but.. > > - from above description it seems that global numbering system is not really > solved :( instead it's been moved one level up and now the same happens with > gpiocipX devices :( Yes that is true, but also the discovery mechanism is changed so it should not be a problem: by traversing /sys/bus/gpio/* you know from the topology information which GPIO chip is which. This is the same method that e.g. USB, IIO or disks use: you have to complement the device name with bus information from sysfs. /sys/class/gpio/* on the other hand has no such information: it is flat. But as I wrote in the other mail in response to Mark Rutland: if it is desired to have predictable numbering of the GPIO chips the exact same alias method can be used for that, and a patch utilizing aliases should fix also this for the character device usecase. My own position on these aliases is "eating popcorn", I'm happy with it, happy without it, the people who care need to argue for it with the DT maintainers. > Wouldn't it be reasonable to add possibility to create named/labeled > gpiocipX devices from the very beginning, like: "/dev/gpiocipX[_name|label], or "/dev/gpiocip[_name|label]", or .. > > Actually, struct gpio_chip has label field already. I don't think that would be nice. There is an ioctl() to get that information (amongst other stuff) from the device. Check tools/gpio/lsgpio.c > PS. From my experience, the worst case with dev numbering usually happens after > few insmod/rmmod (or sometimes after suspend/resume) iterations - ttyX ;..(. In the GPIO case I think the numbers will be reused as we're using <linux/idr.h> infrastructure (same method as IIO). Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
