On Mon, Jun 20, 2016 at 5:57 PM, Rob Herring <robh@xxxxxxxxxx> wrote: > On Fri, Jun 17, 2016 at 11:51:03AM +0200, Neil Armstrong wrote: >> +Optional Properties: >> +- oscio-is-gpo: Boolean, Indicated the oscio pin can be used as additional >> + output gpo port. >> + > >> +- pull-up-ports: Array of port numbers which must have pull-up enabled. >> +- pull-down-ports: Array of port numbers which must have pull-down enabled. >> +- open-drain-ports: Array of port numbers which must be configured as open-drain, >> + Push-Pull mode is default. >> +- polarity-invert-ports: Array of port numbers whih port polarity must be inverted. > > Seems like these should be done in a common way. > > If not, they all need a vendor prefix. Actually on second look, this takes the sx150 to pin control territory. I am starting to feel like a move to drivers/pinctrl/* might be warranted. Neil you worked on other pin controllers IIRC, do you think it would be much work to make a combined GPIO+pinctrl driver and move this over to drivers/pinctrl? I know refactoring across subsystems can be a pain, but at least I'm maintaining both and happy to help out. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html