Hi, On Fri, Jun 17, 2016 at 05:56:02PM +0800, luoyi.ly@xxxxxxxxx wrote: > From: Luo Yi <luoyi.ly@xxxxxxxxx> > > Add support for the Bananapi M1 Plus A20 development board from > sinovoip.com.cn . This board is nearly a clone of the Lemaker's > Bananapro, but differ with the wlan chipset connection and i2s pinout. > And I also enable the integrated audio codec on default. This patch content is fine, but there's a lot of small issues: - You're not indenting the nodes properly - You're missing your Signed-off-by tag - And probably other stuff This has all been reported by checkpatch. Make sure you run checkpatch, make the modifications needed so that you don't have any warnings or errors anymore, and resubmit it. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature