On Mon, 2016-06-20 at 19:09 +0200, Matthias Brugger wrote:
> >>> + uart_clk: dummy26m {
> >>> + compatible = "fixed-clock";
> >>> + clock-frequency = <26000000>;
> >>> + #clock-cells = <0>;
> >>> + };
> >>> +
> >>
> >> We can do that, but I would prefer to see the clock driver early. So
> >> that the DTS we carry around as complete as possible.
> >>
> >
> > OK, I will merge the clk later. However, the clk driver would be
> > submmited later, is that OK? Or would you prefer sunmmit clk driver
> > together?
> >
>
> The uart won't work without any clock node. It is OK like this. I just
> wanted to emphasis that we should try to get the clock driver accpeted
> early in the effort.
>
> Thanks,
> Matthias
Got it. I will not include the clk dts & driver in basic chip patch
v2.We will submmit clk driver soon after this basic chip support patch.
Thanks.
>
> >>> + timer {
> >>> + compatible = "arm,armv8-timer";
> >>> + interrupt-parent = <&gic>;
> >>> + interrupts = <GIC_PPI 13
> >>> + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> >>> + <GIC_PPI 14
> >>> + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> >>> + <GIC_PPI 11
> >>> + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
> >>> + <GIC_PPI 10
> >>> + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
> >>> + };
> >>> +
> >>> + sysirq: intpol-controller@10200620 {
> >>> + compatible = "mediatek,mt6755-sysirq",
> >>> + "mediatek,mt6577-sysirq";
> >>> + interrupt-controller;
> >>> + #interrupt-cells = <3>;
> >>> + interrupt-parent = <&gic>;
> >>> + reg = <0 0x10200620 0 0x20>;
> >>> + };
> >>> +
> >>> + gic: interrupt-controller@10231000 {
> >>> + compatible = "arm,gic-400";
> >>> + #interrupt-cells = <3>;
> >>> + interrupt-parent = <&gic>;
> >>> + interrupt-controller;
> >>> + reg = <0 0x10231000 0 0x1000>,
> >>> + <0 0x10232000 0 0x2000>,
> >>> + <0 0x10234000 0 0x2000>,
> >>> + <0 0x10236000 0 0x2000>;
> >>> + };
> >>> +
> >>> + uart0: serial@11002000 {
> >>> + compatible = "mediatek,mt6755-uart",
> >>> + "mediatek,mt6577-uart";
> >>> + reg = <0 0x11002000 0 0x400>;
> >>> + interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>;
> >>> + clocks = <&uart_clk>;
> >>
> >> status = "disabled";
> >
> > OK, will fix this.
> >>
> >>> + };
> >>> +
> >>> + uart1: serial@11003000 {
> >>> + compatible = "mediatek,mt6755-uart",
> >>> + "mediatek,mt6577-uart";
> >>> + reg = <0 0x11003000 0 0x400>;
> >>> + interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_LOW>;
> >>> + clocks = <&uart_clk>;
> >>
> >> same here.
> >
> > OK, will fix this.
> >
> > Thanks.
> >>
> >> Regards,
> >> Matthias
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
