On Wed, Jun 15, 2016 at 4:47 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Tue, Jun 14, 2016 at 06:32:24PM -0500, Rob Herring wrote: >> On Mon, Jun 13, 2016 at 12:52:40PM +0200, Sylwester Nawrocki wrote: > >> > +Samsung Exynos5433 TM2(E) audio complex with WM5110 codec > >> > +Required properties: > >> > + - compatible : "samsung,tm2-audio" > >> SoC specific compatible string please. > > No, this isn't a SoC IP - this is a binding for a board called TM2(E) > which has a bunch of chips on it including this. Okay, good. > >> > + - samsung,i2s-controller : the phandle of the I2S controller >> > + - samsung,speaker-amplifier : the phandle of the MAX98504 amplifier > >> We should have standard properties for these. 2nd ones I've seen today. > > No, these aren't fixed roles in a system, you couldn't have standard > handling for them. What do you mean? It is silly for us to put vendor prefixes on all of these. There are dozens of examples in the binding docs of <vendor>,i2s-controller and <vendor>,audio-codec. Yes, dropping just the vendor prefix doesn't buy much (maybe some string space), but it certainly adds nothing. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
