On 06/20/2016 03:15 PM, Rob Herring wrote: >> diff --git a/Documentation/devicetree/bindings/sound/max98504.txt >> b/Documentation/devicetree/bindings/sound/max98504.txt >> > new file mode 100644 >> > index 0000000..7aa5b93 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/sound/max98504.txt >> > @@ -0,0 +1,22 @@ >> > +Maxim MAX98504 class D mono speaker amplifier >> > + >> > +This device supports I2C control interface and an IRQ output signal. It features >> > +a PCM and PDM digital audio interface (DAI) and a differential analog input. > > Where's the IRQ in the binding? It seems I didn't do my homework and didn't add it here, even though the driver currently uses the interrupt. I'll add something like this in next iteration: - interrupts : should specify the interrupt the device is connected to, as described in ../interrupt-controller/interrupts.txt -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html