Hi Alexandre & Nicolas, > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@xxxxxxxxxxxxxxxxxx] > Sent: 2016年6月20日 16:04 > To: Yang, Wenyou <Wenyou.Yang@xxxxxxxxx> > Cc: Rob Herring <robh@xxxxxxxxxx>; Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>; > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Ferre, Nicolas > <Nicolas.FERRE@xxxxxxxxx>; Pawel Moll <pawel.moll@xxxxxxx>; Mark Brown > <broonie@xxxxxxxxxx>; Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>; Kumar > Gala <galak@xxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > usb@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB > suspend > > On 20/06/2016 at 03:16:35 +0000, Yang, Wenyou wrote : > > > Sure, what I mean is that you can try to get the regmap for the SFR in every > case. > > > Depending on whether you were able to get it, you can decide to call > > > ohci_at91_port_suspend/resume or not (just test for sfr_regmap != NULL). > > > > I don't think so. The SFR includes a lot of miscellaneous functions, more than > this one. > > > > I know but this is irrelevant to this discussion. If you need to use the SFR from > another driver you will simply get it from that other driver. > > I that case, you will try to get "atmel,sama5d2-sfr". It is only present on sama5d2 > so you have enough information to know whether or not you can use it to > suspend/resume. I understand what your meaning :). Use "atmel,sama5d2-sfr" compatible to distinguish whether forcibly suspend USB port via SFR or not. I am not sure if it is a better solution. Nicolas, could you give your opinion? > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering http://free-electrons.com Best Regards, Wenyou Yang ?韬{.n?????%??檩??w?{.n????z谵{???塄}?财??j:+v?? ? ???2??璀??摺?囤??z夸z罐?+?????w棹f
