On Tue, Jun 14, 2016 at 10:59:29PM -0700, Andrey Smirnov wrote: > Add DS1341 specific power-saving options that allow to disable certain > functional aspects of the chip in order to minimize its power > consumption. This description doesn't match that you are adding a new binding. It is preferred that bindings are a separate patch. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > --- > .../devicetree/bindings/rtc/dallas,ds1341.txt | 23 ++++++++++++++++++ > drivers/rtc/rtc-ds1307.c | 28 ++++++++++++++++++++++ > 2 files changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > > diff --git a/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > new file mode 100644 > index 0000000..b8be7a4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/dallas,ds1341.txt > @@ -0,0 +1,23 @@ > +* Dallas DS1341 I2C Serial Real-Time Clock > + > +Required properties: > + > +- compatible: Should contain "dallas,ds1341". > + > +- reg: I2C address for chip > + > +Optional properties: > + > +- disable-oscillator-stop-flag : Configure chip to disable oscillator > + fault detection circuitry > + > +- enable-glitch-filter : Configure chip to enable crystal oscillator > + output glitch filtering What determines setting these properties or not? They should have vendor prefix and be explicit that they are boolean. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
