Hi! > > > + .reglist = { > > > + { .ptr = &mode1_poweron_mode2_16vga_2592x1968_12_07fps }, > > > + { .ptr = &mode1_16vga_2592x1968_13_12fps_dpcm10_8 }, > > > + { .ptr = &mode3_4vga_1296x984_29_99fps_dpcm10_8 }, > > > + { .ptr = &mode4_svga_864x656_29_88fps }, > > > + { .ptr = &mode5_vga_648x492_29_93fps }, > > > + { .ptr = &mode2_16vga_2592x1968_3_99fps }, > > > + { .ptr = &mode_648x492_5fps }, > > > + { .ptr = &mode3_4vga_1296x984_5fps }, > > > + { .ptr = &mode_4vga_1296x984_25fps_dpcm10_8 }, > > > + { .ptr = 0 } > > > + } > > > +}; > > > > I'd say .ptr = NULL. > > > > Anyway, this code was generated from configuration ini files and perl > script available from: https://gitorious.org/omap3camera/camera-firmware > > Originally in Maemo above C structure is compiled into binary file and > via request_firmware() loaded from userspace to kernel driver. > > For me this sounds like a big overkill, so I included above reglist code > direcly into et8ek8 kernel driver to avoid request_firmware() and > separate userspace storage... Yep, that makes sense, thanks for explanation. I guess that means that we should put a comment on top of the file explaining what is going on. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html