On 06/17/2016 07:00 AM, Chris Lapa wrote: > From: Chris Lapa <chris@xxxxxxxxxxx> > > The max8903_charger.h file indicated that dcm and dok were not optional > when dc_valid is set. > > It makes sense to have dok as a compulsory pin when dc_valid is given. > However dcm can be optionally wired to a fixed level especially when the > circuit is configured for dc power exclusively. > > The previous implementation already allowed for this somewhat, however no > error was given if dok wasn't given whilst dc_valid was. > > The new implementation enforces dok presence when dc_valid is given. Whilst > allowing dcm to be optional. > > Signed-off-by: Chris Lapa <chris@xxxxxxxxxxx> > --- > drivers/power/max8903_charger.c | 23 ++++++++++------------- > include/linux/power/max8903_charger.h | 6 +++--- > 2 files changed, 13 insertions(+), 16 deletions(-) Code looks correct: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
