Hi,
Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> writes:
> On Fri, Nov 22, 2013 at 09:07:01PM +0100, Arnaud Ebalard wrote:
>> mdio {
>> phy0: ethernet-phy@0 {
>> + compatible = "marvell,88e1318s";
>> reg = <0>;
>> };
>>
>> phy1: ethernet-phy@1 {
>> + compatible = "marvell,88e1318s";
>> reg = <1>;
>> };
>> };
>
> Just an inquiry, are these compatible strings OK?
>
> Documentation/devicetree/bindings/net/phy.txt doesn't really give
> guidance.
>
> For self-discoverable busses I would expect to see a structured
> compatible string, or property, that encodes the phy-id - such as what
> the PCI binding does with vid/did:
>
> "compatible" Construct a list of names in most-specific to
> least-specific order. The names shall be derived from
> values of the Vendor ID, Device ID, Subsystem Vendor ID,
> Subsystem ID, Revision ID and Class Code bytes, and shall
> have the following form, and be placed in the list in the
> following order:
>
> pciVVVV,DDDD.SSSS.ssss.RR (1)
>
> So, I would think something like this:
>
> compatible = "ethernet-phy-id0141,0e90"; /* Marvell 88E1318 */
The compatible string I put is based on this discussion:
http://www.spinics.net/lists/devicetree/msg11465.html
Now, considering the following:
arno@small:linux$ grep -R -88e1318s . | wc -l
0
and also the fact that *in my case* the kernel does its job
auto-detecting the PHY, I now also wonder how the kernel can
use that info and what I get by adding the compatible string.
Anyway, I'll wait for directions on how this should be fixed
before sending a v2 of the set.
Thanks for catching this, Jason.
Cheers,
a+
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
