Hello Laxman, On 06/16/2016 09:23 AM, Laxman Dewangan wrote: > Maxim Max77620 has one 32KHz clock output and the clock HW > IP used on this PMIC is same as what it is there in the MAX77686. > > Add clock driver support for MAX77620 on the MAX77686 driver. > > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx> > CC: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > CC: Javier Martinez Canillas <javier@xxxxxxxxxxxx> > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx> > Tested-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > I already gave you my Reviewed-by for v1 but it seems you missed: Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> > --- > Changes from V1: > - Updated based on changes done in first patch. > --- > drivers/clk/Kconfig | 7 ++++--- > drivers/clk/clk-max77686.c | 18 ++++++++++++++++++ > 2 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 6afad74..d75f4c5 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -32,10 +32,11 @@ config COMMON_CLK_WM831X > source "drivers/clk/versatile/Kconfig" > > config COMMON_CLK_MAX77686 > - tristate "Clock driver for Maxim 77686/77802 MFD" > - depends on MFD_MAX77686 > + tristate "Clock driver for Maxim 77686/77802/MAX77620 MFD" > + depends on MFD_MAX77686 || MFD_MAX77620 > ---help--- > - This driver supports Maxim 77686/77802 crystal oscillator clock. > + This driver supports Maxim 77686/77802/MAX77620 crystal oscillator And it seems you also missed the minor nit I mentioned in v1 about using 77620 instead of MAX77620 here for naming consistency with the other IP. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
