On Wed, Nov 20, 2013 at 08:07:45PM +0000, Loc Ho wrote: > Hi, > > >> +- compatible : Shall be "apm,xgene-ahci-phy" or > >> + "apm,xgene-ahci-phy2". The "apm,xgene-ahci-phy" > >> + describes an port shared with SGMII Ethernet port. > >> + The "apm,xgene-ahci-phy2" describes an port not > >> + shared with SGMII and the PLL located at another > >> + memory resource region. > > > > Is there not a better name available than "apm,xgene-ahci-phy2"? > [Loc Ho] > I will name it apm,xgene-ahci-phyx. > > >> +- reg : First PHY memory resource > >> + Second separate PHY PLL clock memory resource if > >> + type "apm,xgene-ahci-phy2" > > > > Is ths PLL actually part of the PHY, or does it just feed the PHY? > [Loc Ho] > This is always the PLL clock macro in each IP. For the 3rd controller, > we require an extra clock macro and can NOT use the original clock > macro as it is not mux'ed with the SGMII port. Ok. Is the reference clock into the PLL always on, or might we need to describe it? > > > > >> +- txeyetuning : Manual control to fine tune the capture of the serial > >> + bit lines from the automatic calibrated position. > >> + Two set of 3-tuple setting for Gen1, Gen2, and Gen3. > >> + Range from 0 to 0x7f. Default is 0xa. > > > > If you have a property for which the name consists of multiple words, > > split the words with '-'. > > > > What does this actually mean? > > > > What units are these values in? > > > > What effect do those values have? > [Loc Ho] > Will provide in next version. Cheers. > > > > >> +- txeyedirection : Eye tuning manual control direction. 0 means sample > >> + data earlier than the nominal sampling point. 1 means > >> + sample data later than the nominal sampling point. > >> + Two set of 3-tuple setting for Gen1, Gen2, and Gen3. > >> + Default is 0x0. > > > > Likewise, use '-'. > > > > s/than/then/ ? > [Loc Ho] > I believe that than is appropriate here a we are doing an comparison. Apologies, you are corerct; I completely misread this. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
