Re: [PATCH] of: irq: don't return 0 from of_irq_get()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 6/3/2016 3:14 PM, Rob Herring wrote:

of_irq_get() returns 0 iff irq_create_of_mapping() call fails. Returning
both error code  and 0 on failure is a sign of a misdesigned API. Return
-ENXIO instead like one of the callers, platform_get_irq(), does; fix up
the kernel-doc as well...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

So I think this is done this way because of the variation in NO_IRQ
definition across architectures.

I remember that NO_IRQ is "considered harmful" by Linus. Actually, I'm nit sure what you mean, could you elaborate on that?

But then again, of_irq_get is
relatively new.

Rob

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux