Hi Mark,
On Fri, Jun 10, 2016 at 01:37:55AM +0100, Mark Brown wrote:
> > > > +static int sun4i_i2s_dai_probe(struct snd_soc_dai *dai)
> > > > +{
> > > > + struct sun4i_i2s *i2s = snd_soc_dai_get_drvdata(dai);
>
> > > > + /* Enable the whole hardware block */
> > > > + regmap_write(i2s->regmap, SUN4I_I2S_CTRL_REG,
> > > > + SUN4I_I2S_CTRL_GL_EN);
>
> > > Runtime PM? It also seems like this is something that ought to be
> > > covered in the suspend and resume callbacks.
>
> > runtime_pm is supported, and uses the regmap cache to keep those
> > changes.
>
> No, my point is that I'd expect to see the block powered off on suspend.
It is. The bus clock is disabled, which also puts the IP in reset.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
