On 08/06/16 18:02, Andrew Donnellan wrote:
On 08/06/16 16:50, Gavin Shan wrote:The function is unflattening device sub-tree blob if @dad passed to the function is valid. Currently, this functionality is used by PPC PowerNV PCI hotplug driver only. There are possibly multiple nodes in the first level of depth, fdt_next_node() bails immediately when @depth becomes negative before the second device node can be probed successfully. It leads to the device nodes except the first one won't be unflattened successfully. This fixes the issue by setting the initial depth (@inital_depth) to 1 when this function is called to unflatten device sub-tree blob. No logic changes when this function is used to unflatten non-sub-tree blob. Cc: Rhyland Klein <rklein@xxxxxxxxxx> Fixes: 78c44d910 ("drivers/of: Fix depth when unflattening devicetree") Signed-off-by: Gavin Shan <gwshan@xxxxxxxxxxxxxxxxxx>This doesn't appear to work for me - in my cxl use case, at first glance it looks like we're getting an empty unflattened device tree returned. Will investigate further.
Can confirm though that that I was observing the original problem here with 78c44d9 when hotplugging a PCI device and only getting 1 PCI function added to the devicetree.
-- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@xxxxxxxxxxx IBM Australia Limited -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
