Hi Sergei, On Fri, Jun 3, 2016 at 11:26 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > The initial R8A7792 SoC device tree including CPU core, GIC, timer, SYSC, > and the required clock descriptions. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > --- > Changes in version 2: > - created the "soc" subnode, moving the SoC device nodes there; > - removed the "clocks" node, moving its fixed clock subnodes to the root and > the MSTP subnodes into the "soc" node. > > arch/arm/boot/dts/r8a7792.dtsi | 171 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 171 insertions(+) > > Index: renesas/arch/arm/boot/dts/r8a7792.dtsi > =================================================================== > --- /dev/null > +++ renesas/arch/arm/boot/dts/r8a7792.dtsi > + /* Fixed factor clocks */ > + zs_clk: zs { > + compatible = "fixed-factor-clock"; > + clocks = <&cpg_clocks R8A7792_CLK_PLL1>; > + #clock-cells = <0>; > + clock-div = <6>; > + clock-mult = <1>; > + }; > + p_clk: p { > + compatible = "fixed-factor-clock"; > + clocks = <&cpg_clocks R8A7792_CLK_PLL1>; > + #clock-cells = <0>; > + clock-div = <24>; > + clock-mult = <1>; > + }; > + cp_clk: cp { > + compatible = "fixed-factor-clock"; > + clocks = <&cpg_clocks R8A7792_CLK_PLL1>; > + #clock-cells = <0>; > + clock-div = <3>; > + clock-mult = <1>; > + }; I think the above 3 fixed factor clocks should be children of the "soc" node, as they're generated on-SoC. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html