Hi Florian, > -----Original Message----- > From: Florian Fainelli [mailto:f.fainelli@xxxxxxxxx] > Sent: 07 June 2016 00:06 > To: Pramod Kumar; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; > Kumar Gala; Catalin Marinas; Will Deacon; Kishon Vijay Abraham I; David S. > Miller > Cc: devicetree@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; bcm-kernel-feedback-list@xxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for > Broadcom MDIO bus multiplexer > > On 06/06/2016 05:41 AM, Pramod Kumar wrote: > > Add DT binding doc for Broadcom MDIO bus multiplexer driver. > > > > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> > > Signed-off-by: Pramod Kumar <pramod.kumar@xxxxxxxxxxxx> > > Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > > > > +for example: > > + mdio_mux_iproc: mdio-mux@6602023c { > > I think Rob wanted you to drop the underscores here in favor of dashes, > there > are more below, not critical imho. > I'd changed node name in favor of dashes. I don't think Label could be written with hyphens,"-". "-" in label provides DT parsing error. > > + compatible = "brcm,mdio-mux-iproc"; > > + reg = <0x6602023c 0x14>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + mdio@0 { > > + reg = <0x0>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pci_phy0: pci-phy@0 { > > > -- > Florian Regards, Pramod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
