On Tuesday 07 June 2016 03:22 AM, Rhyland Klein wrote:
On 6/6/2016 2:39 AM, Laxman Dewangan wrote:
On Saturday 04 June 2016 01:52 AM, Rhyland Klein wrote:
+ regulator-disable-ramp-delay = <4080>;
+ regulator-ramp-delay = <27500>;
+ regulator-ramp-delay-scale = <300>;
There is no disable-ramp-delay in mainline.
Please use the correct value for property as:
regulator-ramp-delay = <9000>;
maxim,ramp-rate-setting = <27500>;
instead of regulator-ramp-delay and regulator-ramp-delay-scale.
The property differs from downstream.
regulator-ramp-delay is what you see in platform and
maxim,ramp-rate-setting is what you want in register.
Where does "<9000>" come from in the above comment? It looks like
maxim,ramp-rate-setting sets the slew rate, and regulator-ramp-delay
will as well, but will be ignored if maxim,ramp-delay-setting is set. So
does it ever make sense to have both defined for a regulator? And if
not, should max77620 regulators just use the maxim property and not the
regulator core property?
9000uV/us is what measured ramp delay in the platform after setting the
device register to 27500uV/us.
This is derived from our downstream table as ramp-delay *100/scale
so here 27500 *100/300 is approx to 9000.
This is used when your measured is varied from register configuration
which is true in most of our platform.
If your platform does not have diff then please provide
regulator-ramp-delay only with what you measured.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
