On Thu, 21 Nov 2013 13:43:28 +0100
Grant Likely <grant.likely@xxxxxxxxxx> wrote:
> On Tue, 19 Nov 2013 11:33:05 +0200, Hiroshi Doyu <hdoyu@xxxxxxxxxx> wrote:
> > The following pattern of code is tempting:
> >
> > for (i = 0; !of_parse_phandle_with_args(np, list, cells, i, args); i++)
> >
> > Signed-off-by: Hiroshi Doyu <hdoyu@xxxxxxxxxx>
>
> That's a very minimal commit message. Can you elaborate please.
The above can be:
"
The following pattern of code is tempting to add a new member for
of_property_for_each_*() family as an idiom.
for (i = 0;
!of_parse_phandle_with_args(np, list, cells, i, args); i++)
<do something with "args">;
"
Actual usage is here:
int i;
struct of_phandle_args args;
of_property_for_each_phandle_with_args(dev->of_node, "iommus",
"#iommu-cells", i, &args) {
pr_debug("%s(i=%d) %s\n", __func__, i, dev_name(dev));
if (!of_find_iommu_by_node(args.np))
return -EPROBE_DEFER;
Is this acceptable?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
