Hello, On Fri, 27 May 2016 14:58:11 -0700, Florian Fainelli wrote: > + if (ctrl->nand_version >= 0x0702) > + bits = 7; > if (ctrl->nand_version >= 0x0600) Don't you want an "else if" here ? Otherwise, even for the 7.2 version of your controller bits will be set to 1. Ditto when setting ctrl->max_oob. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html