Re: [PATCH] arm: tegra124: remove commas from unit addresses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 05/27/2016 10:27 AM, Marcel Ziswiler wrote:
Remove commas from unit addresses as suggested by Rob Herring upon me
posting initial Apalis TK1 support:

http://article.gmane.org/gmane.linux.ports.tegra/26608

diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts

-	gpu@0,57000000 {
+	gpu@57000000 {
  		/*
  		 * Node left disabled on purpose - the bootloader will enable
  		 * it after having set the VPR up

The last time a similar patch was proposed[1], I pointed out that U-Boot uses the node name to enable the node, so this change will break GPU functionality on this board. U-Boot has since been updated to find the node to enable using compatible value rather than hard-coding the node name, but this doesn't help people with existing bootloader binaries; kernel changes shouldn't force them to upgrade the bootloader. I think the DT node names are part of the ABI and shouldn't be changed. We can fix this for completely new SoCs, but not existing SoCs.

[1] http://www.spinics.net/lists/devicetree/msg122164.html "[PATCH] ARM: tegra: Remove 0, prefix from unit-addresses".

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux