On Mon, Nov 18, 2013 at 8:36 PM, Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > > Hi Rob, Mark > >> >> +Required properties: >> >> + >> >> +- compatible : "simple-audio" >> >> Still not really a fan of this generic name. Can we define in the >> description above what simple means. > > So, how about "simple-audio-card" ? That's missing my point. First, I think you should be defining the actual h/w in the DT and doing the mapping of that to a simple audio driver in the kernel. Otherwise how do you fix some quirk on a particular platform later on without updating the DTB? I'm fine with this being the default compatible string, but you should also require a more specific name. Perhaps it is just <soc>-simple-audio or <board>-simple-audio. Second, you need to define in this binding document what simple means. What properties of the audio subsystem make it simple? The h/w has and doesn't have what? How do I decide if my platform can or should use this binding? Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html