On 26/05/16 09:17, Neil Armstrong wrote: > Hi Carlo, Hi Neil, > On 05/25/2016 10:18 PM, Carlo Caione wrote: > > diff --git a/include/dt-bindings/firmware/meson-sm.h b/include/dt-bindings/firmware/meson-sm.h > > new file mode 100644 > > index 0000000..3a52a13 > > --- /dev/null > > +++ b/include/dt-bindings/firmware/meson-sm.h > > @@ -0,0 +1,20 @@ > > +/* > > + * Copyright (C) 2016 Endless Mobile, Inc. > > + * Author: Carlo Caione <carlo@xxxxxxxxxxxx> > > + * > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License > > + * version 2 as published by the Free Software Foundation. > > + * > > + * You should have received a copy of the GNU General Public License > > + * along with this program. If not, see <http://www.gnu.org/licenses/>. > > + */ > > + > > +#ifndef _MESON_DT_H_ > > +#define _MESON_DT_H_ > > + > > +#define SM_EFUSE_READ 0 > > +#define SM_EFUSE_WRITE 1 > > +#define SM_EFUSE_USER_MAX 2 > > + > > +#endif /* _MESON_DT_H_ */ > > Now this has been refactored, I don't see the point of this dt-bindings header ? > > These defines should take place in linux/firmware/meson/meson-sm.h Yes, that is a possibility I considered before submitting this version and now it also seems probably the best way to do it. I'll change it in the next revision. Thanks, -- Carlo Caione -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html