On Wed, May 25, 2016 at 12:28:00PM -0500, Rob Herring wrote: > On Mon, May 23, 2016 at 04:13:57PM -0700, Nicolin Chen wrote: > > + - VA-supply, VP-supply : power supplies for the device, > > + as covered in Documentation/devicetree/bindings/regulator/regulator.txt. > Also, these are missing from the example yet are required. I'd argue > they should be optional as you could have designs with no regulator > control. The general rule is that regulators should only be omitted if they are physically absent, we can describe simple fixed supplies with no control so we should do so (though in practice Linux is much more forgiving and will provide one if the supply is just plain missing from the DT). This is a simpler rule for people to follow than making them officially optional and is more robust in the face of things like implementation changes that allow supplies to become controlable or drivers that suddenly form a desire to look at their supply voltages, as well as allowing other OSs to have simpler implementations if it's followed.
Attachment:
signature.asc
Description: PGP signature
