Re: [rtc-linux] [PATCHv2] rtc: Add support for Intersil ISL12057 I2C RTC chip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, Nov 18, 2013 at 09:51:27PM +0100, Arnaud Ebalard wrote:

> +/* Block read. Returns 0 on success, or a negative errno. */
> +static int isl12057_i2c_read_regs(struct i2c_client *client, u8 reg, u8 buf[],
> +				  unsigned len)

This looks like the device would work well with regmap (8 bit register,
8 bit data).  This would save a bit of code here both for the I/O
functions and also for some of the debugging functionality you have
below like the proc file.

> +	dev_info(dev, "chip found, driver version " DRV_VERSION "\n");

This sort of print is generally frowned upon - it's not adding anything
to the message already displayed by the RTC core on registration.  It's
probably best to remove the driver version too, the kernel is already
versioned.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux