On Mon, May 23, 2016 at 11:47:04AM +0100, Mark Rutland wrote: > > +/* Regulator operating modes */ > > +#define REGULATOR_OPERATION_MODE_FAST 0x0 > > +#define REGULATOR_OPERATION_MODE_NORMAL 0x1 > > +#define REGULATOR_OPERATION_MODE_IDLE 0x2 > > +#define REGULATOR_OPERATION_MODE_STANDBY 0x3 > These sound like they're tied to linux internal details (e.g. the > implementation of idle and/or suspend). > What do each of these actually mean? They are not really at all general and I'm fairly sure I've provided the same feedback repeatedly on earlier versions of the patch set. They are not entirely based on Linux internal details (or at least the Linux internal details tend to flow from the hardware) - broadly fast is forced PWM, normal is default, idle is LDO mode and standby is a lower quality LDO mode - but how this translates into anything that a consumer could actually use is unclear since the supported output loads and quality of regulation can vary wildy. It's also somewhat implementation dependent what a given regulator does (and it's always possible that some regulators may have more modes to control or differing definitions in the hardware). Henry, *please* look at how the existing mode support in the bindings is done and consider how a consumer would use this given that it doesn't know anything about the regulator...
Attachment:
signature.asc
Description: PGP signature
