Shawn, On Thu, May 19, 2016 at 6:48 PM, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote: >>> #define EXT_CSD_BUS_WIDTH_1 0 /* Card is in 1 bit mode */ >>> #define EXT_CSD_BUS_WIDTH_4 1 /* Card is in 4 bit mode */ >>> #define EXT_CSD_BUS_WIDTH_8 2 /* Card is in 8 bit mode */ >>> #define EXT_CSD_DDR_BUS_WIDTH_4 5 /* Card is in 4 bit DDR >>> mode */ >>> #define EXT_CSD_DDR_BUS_WIDTH_8 6 /* Card is in 8 bit DDR >>> mode */ >>> +#define EXT_CSD_BUS_WIDTH_STROBE BIT(7) /* Enhanced strobe mode >>> */ >> >> >> nit: while your code should be OK, it seems better to be BIT(3), since >> above is really: >> > > I don't unstand here. EXT_CSD_BUS_WIDTH_STROBE is the MSB of > BUS_WIDTH[183] which is a 8-bit reg. I totally misunderstood. You are correct. -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html