On Fri, May 13, 2016 at 01:03:27PM +0300, Roger Quadros wrote: > + > +static int usb_gadget_connect_control(struct usb_gadget *gadget, bool connect) > +{ > + struct usb_udc *udc; > + > + mutex_lock(&udc_lock); > + udc = usb_gadget_to_udc(gadget); > + if (!udc) { > + dev_err(gadget->dev.parent, "%s: gadget not registered.\n", > + __func__); > + mutex_unlock(&udc_lock); > + return -EINVAL; > + } > + > + if (connect) { > + if (!gadget->connected) > + usb_gadget_connect(udc->gadget); > + } else { > + if (gadget->connected) { > + usb_gadget_disconnect(udc->gadget); > + udc->driver->disconnect(udc->gadget); > + } > + } > + > + mutex_unlock(&udc_lock); > + > + return 0; > +} > + Since this is called for vbus interrupt, why not using usb_udc_vbus_handler directly, and call udc->driver->disconnect at usb_gadget_stop. > return 0; > @@ -660,9 +830,15 @@ static ssize_t usb_udc_softconn_store(struct device *dev, > return -EOPNOTSUPP; > } > > + /* In OTG mode we don't support softconnect, but b_bus_req */ > + if (udc->gadget->otg_dev) { > + dev_err(dev, "soft-connect not supported in OTG mode\n"); > + return -EOPNOTSUPP; > + } > + The soft-connect can be supported at dual-role mode currently, we can use b_bus_req entry once it is implemented later. > if (sysfs_streq(buf, "connect")) { > usb_gadget_udc_start(udc); > - usb_gadget_connect(udc->gadget); > + usb_udc_connect_control(udc); This line seems to be not related with this patch. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html